contrib/bradfitz/gomemcache/memcache: use naming schema #1820
+52
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -176,6 +178,106 @@ func TestAnalyticsSettings(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestNamingSchema(t *testing.T) { | |||
There was a problem hiding this comment.
Can this be a shared test across all contrib libararies?
There was a problem hiding this comment.
Added a package contrib/internal/namingschematest with shared testing logic, please let me know if this is what you had in mind
rarguelloF
force-pushed
the
rarguelloF/naming-schema-memcached
branch
from
18a78d8 to
3df1707
Compare
rarguelloF
force-pushed
the
rarguelloF/naming-schema-api
branch
2 times, most recently
from
e42132a to
2e3b0a7
Compare
…ma versioning testing logic
…nd operation name
rarguelloF
force-pushed
the
rarguelloF/naming-schema-memcached
branch
from
3df1707 to
04d61af
Compare
ajgajg1134
reviewed
Apr 10, 2023
| ) | ||
|
|
||
| // NewMemcachedOpNameTest generates a new test for memcached span operation names using the naming schema versioning. | ||
| func NewMemcachedOpNameTest(genSpans GenSpansFn) func(t *testing.T) { |
There was a problem hiding this comment.
Is this function only used in exactly one place?
There was a problem hiding this comment.
yes! my intention with this was to create a generic test for memcached integrations, but since we only have one it makes sense to move it there. Thanks for pointing out!
ajgajg1134
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements naming schema versioning for all memcached integrations:
bradfitz/gomemcache/memcacheMotivation
Improve service and operation names.
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.