Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/hashicorp/consul: use naming schema #1821

Merged
merged 15 commits into from
Apr 11, 2023
Merged

contrib/hashicorp/consul: use naming schema #1821

merged 15 commits into from
Apr 11, 2023
+53 −3

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Mar 22, 2023 •
edited
Loading

What does this PR do?

Implements naming schema versioning for hashicorp/consul package.

Motivation

Improve service and operation names.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@rarguelloF rarguelloF changed the base branch from main to rarguelloF/naming-schema-api March 22, 2023 17:10
@pr-commenter
Copy link

pr-commenter bot commented Mar 22, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit 419ecd2 in PR branch rarguelloF/naming-schema-consul with baseline commit 4d35962 in branch rarguelloF/naming-schema-kafka.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@rarguelloF rarguelloF force-pushed the rarguelloF/naming-schema-consul branch from e2c4cf9 to ca18786 Compare March 27, 2023 15:47
@rarguelloF rarguelloF force-pushed the rarguelloF/naming-schema-api branch 2 times, most recently from e42132a to 2e3b0a7 Compare March 31, 2023 10:25
Base automatically changed from rarguelloF/naming-schema-api to main April 3, 2023 13:02
@rarguelloF
contrib/Shopify/sarama: use naming schema

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
0d6113b
@rarguelloF
contrib/confluentinc/confluent-kafka-go/kafka: use naming schema

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
b2c83a7
@rarguelloF
contrib/segmentio/kafka.go.v0: refactor tests

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
271d1ae
@rarguelloF
contrib/internal/namingschematest: add package for shared naming sche…

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
31c67fe 
…ma versioning testing logic
@rarguelloF
contrib/kafka: refactor tests using namingschematest package

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
f8a0db8
@rarguelloF
Merge branch 'main' into rarguelloF/naming-schema-kafka

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4d35962
@rarguelloF
contrib/hashicorp/consul: use naming schema

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
6858a71
@rarguelloF rarguelloF force-pushed the rarguelloF/naming-schema-consul branch from ca18786 to 6858a71 Compare April 5, 2023 14:02
@rarguelloF
refactor consul naming schema tests

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
419ecd2
@rarguelloF rarguelloF changed the base branch from main to rarguelloF/naming-schema-kafka April 5, 2023 14:37
@rarguelloF
contrib/internal/namingschematest: refactor package

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
d2075a2
@rarguelloF
Merge branch 'main' into rarguelloF/naming-schema-kafka

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a1fd13a
@rarguelloF
Merge branch 'rarguelloF/naming-schema-kafka' into rarguelloF/naming-…

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
fb2a6c2 
…schema-consul
@rarguelloF
fix import order

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
449a4c7
@rarguelloF rarguelloF marked this pull request as ready for review April 5, 2023 15:25
@rarguelloF rarguelloF requested a review from a team April 5, 2023 15:25
Base automatically changed from rarguelloF/naming-schema-kafka to main April 10, 2023 17:04
@rarguelloF
Merge branch 'main' into rarguelloF/naming-schema-consul

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
9b4bb92
@rarguelloF
fix import order

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
SSH Key Fingerprint: Uw4yLxbLKJ+iRBd5hSL83+nkoJVYR8G4F6/Cl7CouHA
Verified
Learn about vigilant mode
5d84fdf
ajgajg1134
ajgajg1134 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rarguelloF rarguelloF enabled auto-merge (squash) April 11, 2023 08:07
@rarguelloF
Merge branch 'main' into rarguelloF/naming-schema-consul

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2867d7d
@rarguelloF rarguelloF merged commit 743f74f into main Apr 11, 2023
@rarguelloF rarguelloF deleted the rarguelloF/naming-schema-consul branch April 11, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgajg1134 ajgajg1134

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rarguelloF @ajgajg1134