Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/kafka: use naming schema #1827

Merged
merged 13 commits into from
Apr 10, 2023
Merged

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Mar 24, 2023

What does this PR do?

  • Implements naming schema versioning for all kafka integrations:
    • segmentio/kafka.go.v0
    • Shopify/sarama
    • confluentinc/confluent-kafka-go/kafka
  • Adds contrib/internal/namingschematest package containing shared test logic for naming schema versioning.
  • Improves test execution time for confluentinc/confluent-kafka-go/kafka by setting MaxWait config option to test readers to 10ms.

Motivation

Improve service and operation names.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@rarguelloF rarguelloF changed the base branch from main to rarguelloF/naming-schema-api March 24, 2023 16:45
@rarguelloF rarguelloF force-pushed the rarguelloF/naming-schema-kafka branch from 2b17f28 to a205a23 Compare March 24, 2023 16:48
@pr-commenter
Copy link

pr-commenter bot commented Mar 24, 2023

Benchmarks

Comparing candidate commit a1fd13a in PR branch rarguelloF/naming-schema-kafka with baseline commit 1b5ba27 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@rarguelloF rarguelloF force-pushed the rarguelloF/naming-schema-kafka branch 2 times, most recently from 732620f to 0ffe175 Compare March 27, 2023 15:50
@rarguelloF rarguelloF force-pushed the rarguelloF/naming-schema-api branch 2 times, most recently from e42132a to 2e3b0a7 Compare March 31, 2023 10:25
Base automatically changed from rarguelloF/naming-schema-api to main April 3, 2023 13:02
@rarguelloF rarguelloF force-pushed the rarguelloF/naming-schema-kafka branch from 0ffe175 to 271d1ae Compare April 4, 2023 12:25
@rarguelloF rarguelloF marked this pull request as ready for review April 4, 2023 17:18
@rarguelloF rarguelloF requested a review from a team April 4, 2023 17:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just general formatting changes

@rarguelloF rarguelloF requested a review from ajgajg1134 April 10, 2023 09:51
@rarguelloF rarguelloF enabled auto-merge (squash) April 10, 2023 15:36
@rarguelloF rarguelloF merged commit a09c872 into main Apr 10, 2023
@rarguelloF rarguelloF deleted the rarguelloF/naming-schema-kafka branch April 10, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants