-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/telemetry: collect telemetry info for gorilla/mux integration #1861
Conversation
…-trace-go into evan.li/integration-telemetry
BenchmarksComparing candidate commit 3fe7096 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 0 unstable metrics. scenario:BenchmarkConcurrentTracing-24
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is reasonable, and probably as minimally invasive as we're going to get. Thanks!! Just a few small comments.
Co-authored-by: Katie Hockman <katie@hockman.dev>
…-trace-go into evan.li/integration-telemetry
…-trace-go into evan.li/integration-telemetry
Co-authored-by: Katie Hockman <katie@hockman.dev>
Co-authored-by: Katie Hockman <katie@hockman.dev>
Co-authored-by: Katie Hockman <katie@hockman.dev>
What does this PR do?
This PR implements collecting integration info for instrumentation telemetry. Currently it only tracks the
gorilla/mux
contrib package.Unit testing for integration collection is done in
contrib/internal/telemetrytest
.We also add a POC of a test (
TestTelemetryEnabled
) that verifies the expected contrib packages are importing telemetry.Motivation
Collecting telemetry info for integrations will unlock a lot of useful data. In order to collect this data, we will have to add a call to
telemetry.LoadIntegration
inside aninit
function in every contrib package. This PR shows an example of how that might be done and tested incontrib/gorilla/mux
. We can use this example to evaluate whether or not it is worth it to do this and maintain for every contrib package.Describe how to test/QA your changes
There is currently a unit test in
contrib/gorilla/mux
, and we probably want to manual test with a sample app or with system tests as well. There is currently not a system test for integration collection.Reviewer's Checklist