contrib: load telemetry info for all integrations #1882
Conversation
contrib/garyburd/redigo/redigo.go
Outdated
|
|
||
| redis "github.com/garyburd/redigo/redis" | ||
| ) | ||
|
|
||
| func init() { | ||
| telemetry.LoadIntegration("garyburd/redigo/redis") |
There was a problem hiding this comment.
Should this just be garyburd/redigo?
There was a problem hiding this comment.
Oh strange. We named this package incorrectly based on our contrib requirements. So @lievan used the name of the package instead of the name of the directory.. which I would actually say is correct. Wdyt?
There was a problem hiding this comment.
Looks like this has happened in a few places (e.g. contrib/google.golang.org/api/api.go)
There was a problem hiding this comment.
Based on our convo, yep it should be garyburd/redigo to match the component tag 👍
contrib/google.golang.org/api/api.go
Outdated
There was a problem hiding this comment.
Want to use the new component constant here as well? (see line 66)
There was a problem hiding this comment.
This file also has a couple other uses of the component
…og/dd-trace-go into evan.li/all-integrations-telemetry
Co-authored-by: Andrew Glaude <andrew.glaude@datadoghq.com>
…og/dd-trace-go into evan.li/all-integrations-telemetry
What does this PR do?
This PR enables instrumentation telemetry data for all integrations. The integration name is defined by the path after
contrib.For example for
contrib/99designs/gqlgen, we addMotivation
Describe how to test/QA your changes
Reviewer's Checklist