Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: bump emicklei/go-restful to v2.16.0 #1885

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Bump emicklei/go-restful to v2.16.0

Motivation

Describe how to test/QA your changes

The contrib tests pass.

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
@ahmed-mez ahmed-mez marked this pull request as ready for review April 11, 2023 12:13
@ahmed-mez ahmed-mez requested a review from a team as a code owner April 11, 2023 12:13
@nsrip-dd
Copy link
Contributor

Our tests pass, but are there any incompatible changes between this version and the old version? They have different major version numbers. I realize that there is a vulnerability report for all but this version of the library, but I'm wondering if it could break user programs to upgrade.

@ahmed-mez
Copy link
Contributor Author

They have different major version numbers.

I don't think so, the v2 is older than the commit that we were pinning

Am I missing something?

Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version this PR upgrades to is newer: https://github.com/emicklei/go-restful/releases/tag/v2.16.0

But, I'm mainly just being paranoid :D I compared the two versions and didn't see any incompatible API changes. Thanks!

@ahmed-mez
Copy link
Contributor Author

Thanks for the extra 👀 - appreciate it!

Verified

This commit was signed with the committer’s verified signature.
rarguelloF Rodrigo Argüello
@ahmed-mez ahmed-mez enabled auto-merge (squash) April 11, 2023 15:48
@ahmed-mez ahmed-mez disabled auto-merge April 11, 2023 15:48
@pr-commenter
Copy link

pr-commenter bot commented Apr 11, 2023

Benchmarks

Comparing candidate commit d15b216 in PR branch ahmed/bump-go-restful with baseline commit ed97da6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@ahmed-mez ahmed-mez merged commit 5dfc38c into main Apr 11, 2023
@ahmed-mez ahmed-mez deleted the ahmed/bump-go-restful branch April 11, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants