-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/aws/aws-sdk-go-v2: add aws_service, region, and resourcename #1888
Conversation
…ataDog/dd-trace-go into ar/ConsistentApmSpanTagsForAwsRequests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I didn't review the tests yet, but here are some starting comments for the main aws.go
file changes.
Could you please update the PR description to meet the criteria described here: https://github.com/DataDog/dd-trace-go/blob/main/CONTRIBUTING.md#contributing
We also try to avoid linking to internal documentation in the PR descriptions. That can be sent via Slack instead to provide any necessary context for our review. Can you remove those links from the PR description?
…ataDog/dd-trace-go into ar/ConsistentApmSpanTagsForAwsRequests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits, but otherwise looks good. Thanks!
7513ed5
to
78aa78f
Compare
What does this PR do?
Adds
Motivation
Serverless inferred related resources, pivot from traces to aws integration metrics ootb
Describe how to test/QA your changes
Reviewer's Checklist