Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/go.mod: bump datadog-agent/pkg/obfuscate #1890

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

zekth
Copy link
Contributor

@zekth zekth commented Apr 12, 2023

What does this PR do?

This bumps datadog-agent/pkg/obfuscate

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
mikededo Miquel de Domingo i Giralt
@zekth zekth requested a review from a team as a code owner April 12, 2023 09:19
@ahmed-mez ahmed-mez added this to the v1.50.0 milestone Apr 12, 2023
ahmed-mez
ahmed-mez previously approved these changes Apr 12, 2023
@ahmed-mez ahmed-mez enabled auto-merge (squash) April 12, 2023 11:18

Verified

This commit was signed with the committer’s verified signature.
mikededo Miquel de Domingo i Giralt
@zekth
Copy link
Contributor Author

zekth commented Apr 12, 2023

@ahmed-mez what happened in 1e6b545 ? I'm really confused about the state of ristretto

@ahmed-mez ahmed-mez disabled auto-merge April 12, 2023 11:54
@ahmed-mez
Copy link
Contributor

@ahmed-mez what happened in 1e6b545 ? I'm really confused about the state of ristretto

I'm trying to understand why it broke one of the tests see https://github.com/DataDog/dd-trace-go/actions/runs/4676693394/jobs/8285688545

@ahmed-mez
Copy link
Contributor

@zekth looks like datadog-agent/pkg/obfuscate v0.43.1 still uses ristretto v0.2.0. This fix will be in datadog-agent/pkg/obfuscate v0.45.0

@zekth
Copy link
Contributor Author

zekth commented Apr 12, 2023

I mean i don't get why it gets different sum between 2 runs.

@ahmed-mez
Copy link
Contributor

Not sure, but perhaps related to outcaste-io/ristretto#7 ?

@ahmed-mez
Copy link
Contributor

I'm going to merge this PR but keep the issue open.

@ahmed-mez ahmed-mez enabled auto-merge (squash) April 12, 2023 12:02
@ahmed-mez ahmed-mez merged commit 84885db into DataDog:main Apr 12, 2023
@zekth zekth deleted the fix/bump-ristreto branch April 12, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants