Skip to content

appsec: add blocking SDK body operation (#1901) #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

Hellzy
Copy link
Contributor

@Hellzy Hellzy commented Apr 18, 2023

#1901 appsec: add blocking SDK body operation

What does this PR do?

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

#1901 adds the http sdk body blocking feature the feature is divided as follows:

* Modifying the appsec api: adding appsec.MonitorParsedHTTPBody an error as return value
* Adding a call to the WAF to check for security event synchronously with a call to appsec.MonitorParsedHTTPBody on the body passed as parameter
* Removing the call to the WAF done on the body an the end of a request because we moved it.
* Refactoring the waf addresses storage and access

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@Hellzy Hellzy requested a review from a team as a code owner April 18, 2023 12:30
@Hellzy Hellzy marked this pull request as draft April 18, 2023 12:32
@pr-commenter
Copy link

pr-commenter bot commented Apr 18, 2023

Benchmarks

Comparing candidate commit dbc2fd8 in PR branch francois.mazeau/release-cherry-pick with baseline commit 154f853 in branch release-v1.50.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@Hellzy Hellzy changed the title appsec: add blocking SDK body operation (#1901) release-v1.50.x: cherry-picks for rc.2 Apr 19, 2023
@Hellzy Hellzy marked this pull request as ready for review April 19, 2023 07:33
@Hellzy Hellzy force-pushed the francois.mazeau/release-cherry-pick branch from a292170 to dbc2fd8 Compare April 19, 2023 07:33
@Hellzy Hellzy changed the title release-v1.50.x: cherry-picks for rc.2 appsec: add blocking SDK body operation (#1901) Apr 19, 2023
@Hellzy Hellzy merged commit 77cc8aa into release-v1.50.x Apr 19, 2023
@Hellzy Hellzy deleted the francois.mazeau/release-cherry-pick branch April 19, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants