ddtrace/trace: only tag fully-covered spans as execution traced #1943
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only label spans as being covered by execution tracing if they are fully covered, i.e. they start and finish with execution tracing enabled. Otherwise, we can see trace tasks which cover a shorter duration than the actual span time, which is confusing.
nsrip-dd
force-pushed
the
nick.ripley/only-mark-completely-traced-spans
branch
from
cbc5e64 to
1bd6889
Compare
felixge
previously approved these changes
May 8, 2023
If a span is paritally covered, a user might still be able to get some use out of seeing the data. Give such spans an annotation, with a different value than for fully-covered spans, so they can find the data.
I added a "partial" case to the existing execution trace span tagging test, so we don't need a new test.
ajgajg1134
approved these changes
May 10, 2023
katiehockman
pushed a commit
that referenced
this pull request
Jun 6, 2023
Only label spans as being covered by execution tracing if they are fully covered, i.e. they start and finish with execution tracing enabled. If we know that a span was partially covered, we can still label it, but with something different so it's clear there is missing information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Only label spans as being covered by execution tracing if they are fully
covered, i.e. they start and finish with execution tracing enabled.
If we know that a span was partially covered, we can still label it, but
with something different so it's clear there is missing information.
Motivation
Currently we can see trace tasks which cover a shorter duration than the actual
span time, which is confusing.
Describe how to test/QA your changes
This PR includes a unit test.
Reviewer's Checklist