Skip to content

appsec: handle user custom rules through remote config #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 9, 2023

Conversation

Hellzy
Copy link
Contributor

@Hellzy Hellzy commented May 4, 2023

What does this PR do?

This allows users to send custom security rules through the ASM remote config product. Custom rules
are processed by the WAF just like regular rules, but are described under a different json field in the rule file (custom_rules). Custom rules can be present along regular rules.

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Hellzy added 4 commits May 3, 2023 16:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Hellzy Hellzy requested review from a team as code owners May 4, 2023 14:38
@Hellzy Hellzy added this to the v1.51.0 milestone May 4, 2023
@Hellzy Hellzy changed the title appsec: handler user custom rules through remote config appsec: handle user custom rules through remote config May 4, 2023
@pr-commenter
Copy link

pr-commenter bot commented May 5, 2023

Benchmarks

Comparing candidate commit 238bd32 in PR branch francois.mazeau/custom-rules with baseline commit 242cc76 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

Hellzy added 4 commits May 5, 2023 16:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Hellzy Hellzy merged commit c9996a7 into main May 9, 2023
@Hellzy Hellzy deleted the francois.mazeau/custom-rules branch May 9, 2023 08:07
katiehockman pushed a commit that referenced this pull request Jun 6, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Julio Guerra <julio@datadog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants