contrib/labstack/echo: Add warning and deprecation notice #1974
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knusbaum
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a warning and deprecation notice for contrib/labstack/echo v3. The old version is no longer under development it seems and has active security vulnerabilities that were addressed in the newer "v4" version that supports go modules. Customers should migrate off the v3 version to v4, and when we release dd-trace-go v2 we should remove support for v3.
Motivation
Customers who are interested in using labstack/echo might not know which version they should prefer when viewing our docs. This warning should help new implementors avoid relying on insecure / outdated software as well as notifying current users that support is deprecated.
Describe how to test/QA your changes
no QA needed
Reviewer's Checklist