Skip to content

contrib/gin-gonic: abort context if request is blocked by appsec #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2023

Conversation

Hellzy
Copy link
Contributor

@Hellzy Hellzy commented May 10, 2023

What does this PR do?

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@Hellzy Hellzy added this to the v1.51.0 milestone May 10, 2023
@pr-commenter
Copy link

pr-commenter bot commented May 10, 2023

Benchmarks

Comparing candidate commit 3857945 in PR branch francois.mazeau/gin-blocking with baseline commit 10c94ab in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@Hellzy Hellzy force-pushed the francois.mazeau/gin-blocking branch from fb7d0a3 to 5ce1019 Compare May 12, 2023 12:36
@Hellzy Hellzy force-pushed the francois.mazeau/gin-blocking branch from 5ce1019 to c062f5f Compare May 12, 2023 12:36
@Hellzy Hellzy marked this pull request as ready for review May 12, 2023 14:06
@Hellzy Hellzy requested a review from a team as a code owner May 12, 2023 14:06
@Julio-Guerra Julio-Guerra merged commit f00d6a6 into main May 12, 2023
@Julio-Guerra Julio-Guerra deleted the francois.mazeau/gin-blocking branch May 12, 2023 21:02
@Julio-Guerra Julio-Guerra added appsec bug unintended behavior that has to be fixed labels May 12, 2023
katiehockman pushed a commit that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec bug unintended behavior that has to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants