contrib: peer.service precursors for confluentinc/segmentio integrations
#1979
+115
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarguelloF
requested changes
May 11, 2023
ajgajg1134
requested changes
May 11, 2023
For confluenctinc, stores value once in struct and adds checks to ensure deprecated wrapper still works For segmentio, stores value once in struct and adds benchmark confirming improvement by 100 ns/op from previous commit Fixed grammar on tag description
rarguelloF
reviewed
May 12, 2023
…s formatting in segmentio tests
ajgajg1134
approved these changes
May 12, 2023
katiehockman
pushed a commit
that referenced
this pull request
Jun 6, 2023
…ations (#1979) Co-authored-by: Andrew Glaude <andrew.glaude@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
-This PR sets the
peer.serviceprecursor for confluentinc and segementio kafka integration spans which is themessaging.kafka.bootstrap.serverstag.-Adds according testing and other modifications to meet requirements