Skip to content

contrib: peer.service precursors for elasticsearch integrations #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 12, 2023
Merged

contrib: peer.service precursors for elasticsearch integrations #1981

merged 6 commits into from
May 12, 2023
+50 −25

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented May 10, 2023 •
edited
Loading

What does this PR do?

  • This PR sets the peer.service precursor for elastic and olivere/elastic elasticsearch integration spans which is the network.destination.hostname tag.
  • This also deprecates the old tags used such as out.host and peer.hostname in order to push the usage of the more appropriate network.destination.hostname tag.
  • Adds testing accordingly and other modifications to meet requirements

zarirhamza added 2 commits May 10, 2023 15:59
@zarirhamza
contrib/elastic/go-elasticsearch.v6: adds precursor tags for elastic

Verified

This commit was signed with the committer’s verified signature.
zarirhamza Zarir Hamza
GPG key ID: B31C1363A1010783
Verified
Learn about vigilant mode
b702572
@zarirhamza
contrib/olivere/elastic: adds precursor tags for olivere/elastic

Verified

This commit was signed with the committer’s verified signature.
zarirhamza Zarir Hamza
GPG key ID: B31C1363A1010783
Verified
Learn about vigilant mode
4eee553
rarguelloF
rarguelloF requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@rarguelloF rarguelloF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just some small changes.

zarirhamza added 2 commits May 11, 2023 12:25
@zarirhamza
Deprecates old tags for new NetworkDestinationName tag

Verified

This commit was signed with the committer’s verified signature.
zarirhamza Zarir Hamza
GPG key ID: B31C1363A1010783
Verified
Learn about vigilant mode
105a0e5
@zarirhamza
Merge branch 'main' into zarir/elasticsearch-precursor-peer.service

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
edf7fd3
@pr-commenter
Copy link

pr-commenter bot commented May 11, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit 9d62052 in PR branch zarir/elasticsearch-precursor-peer.service with baseline commit 3b1462c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@zarirhamza zarirhamza marked this pull request as ready for review May 11, 2023 17:45
@zarirhamza zarirhamza requested a review from a team May 11, 2023 17:45
ajgajg1134
ajgajg1134 approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

rarguelloF
rarguelloF approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@rarguelloF rarguelloF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ajgajg1134 added 2 commits May 12, 2023 11:13
@ajgajg1134
Merge branch 'main' into zarir/elasticsearch-precursor-peer.service

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4cbe21f
@ajgajg1134
Merge branch 'main' into zarir/elasticsearch-precursor-peer.service

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9d62052
@zarirhamza zarirhamza merged commit dc939eb into main May 12, 2023
@zarirhamza zarirhamza deleted the zarir/elasticsearch-precursor-peer.service branch May 12, 2023 15:58
katiehockman pushed a commit that referenced this pull request Jun 6, 2023
@zarirhamza @ajgajg1134 @katiehockman
contrib: peer.service precursors for elasticsearch integrations (#1981
2c2e1e5 
)

Co-authored-by: Andrew Glaude <andrew.glaude@datadoghq.com>
@hannahkm hannahkm mentioned this pull request Sep 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgajg1134 ajgajg1134

@rarguelloF rarguelloF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zarirhamza @ajgajg1134 @rarguelloF