internal/namingschema: add config flag to disable default integration service names #2007
+121
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarguelloF
changed the title
BenchmarksBenchmark execution time: 2023-06-14 09:57:04 Comparing candidate commit 8677744 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
amarziali
reviewed
May 30, 2023
2 tasks
rarguelloF
changed the title
pkalmakis
reviewed
Jun 13, 2023
ajgajg1134
reviewed
Jun 13, 2023
knusbaum
reviewed
Jun 13, 2023
knusbaum
reviewed
Jun 13, 2023
ajgajg1134
previously approved these changes
Jun 13, 2023
knusbaum
previously approved these changes
Jun 13, 2023
dianashevchenko
approved these changes
Jun 14, 2023
rarguelloF
deleted the
rarguelloF/add-default-client-service-names-config
branch
dianashevchenko
pushed a commit
that referenced
this pull request
Jun 14, 2023
… service names (#2007) Co-authored-by: Andrew Glaude <andrew.glaude@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLEDenv variable andWithGlobalServiceNametracer start option.Motivation
The motivation of this flag is to be able to to use the default service names introduced by the naming schema v1 (everything defaults to
DD_SERVICE) while using naming schema v0 (so the operation names remain unchanged).AKA: This allows customers to upgrade to v1 SERVICE names while maintaining their V0 operation names. (Otherwise, V1 changes both service and operation names)
Describe how to test/QA your changes
Reviewer's Checklist