Added WithErrorCheck option to redis #2040
Merged
+135
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a
WithErrorCheck
to the redis packages. I originally created an issue here that was accepted.Motivation
The goal of this option is to have a way to define which error should be marked as a datadog error.
For example, a context.Canceled error could be ignored in datadog.
Describe how to test/QA your changes
I added tests in the different packages, they can be checked to see how to test the changes.
The custom error check function can be added to the client as an option :
Reviewer's Checklist