Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set a bigger timeout for the windows #2059

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

dianashevchenko
Copy link
Contributor

@dianashevchenko dianashevchenko commented Jun 21, 2023

What does this PR do?

This PR increases a timeout by 5 minutes for CI workflows running on Windows. Before adding more tests related to peer.service, the tests were passing at 9m37s, which was very close to failure.

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@dianashevchenko dianashevchenko requested a review from a team as a code owner June 21, 2023 12:28
@pr-commenter
Copy link

pr-commenter bot commented Jun 21, 2023

Benchmarks

Benchmark execution time: 2023-06-21 12:50:40

Comparing candidate commit 2dc6e21 in PR branch shevchenko/ci-timeout with baseline commit 39472a6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@dianashevchenko dianashevchenko force-pushed the shevchenko/ci-timeout branch from 3bfe2b5 to 71eb338 Compare June 21, 2023 12:37
@dianashevchenko dianashevchenko changed the base branch from release-v1.52.x to main June 21, 2023 12:38
@dianashevchenko dianashevchenko requested a review from a team June 21, 2023 12:38
ahmed-mez
ahmed-mez previously approved these changes Jun 21, 2023

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@dianashevchenko dianashevchenko merged commit d95fdb5 into main Jun 21, 2023
@dianashevchenko dianashevchenko deleted the shevchenko/ci-timeout branch June 21, 2023 12:58
dianashevchenko added a commit that referenced this pull request Jun 21, 2023

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants