Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/opentelemetry: improve TestSpanContextWithStartOptions #2063

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

katiehockman
Copy link
Contributor

@katiehockman katiehockman commented Jun 22, 2023

What does this PR do?

Adds a check to the TestSpanContextWithStartOptions OTel test which verifies that the payload contains two spans.

Motivation

This test started failing while we were implementing partial flushing. We found that partial flushing was being triggered when it shouldn't have been, which led to the payload at the end only containing a single span, instead of 2 spans as would be expected. It took longer than necessary to realize that's why the test was failing though, so this just makes it easier to spot the root cause if this test fails in that way again.

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@katiehockman katiehockman marked this pull request as ready for review June 22, 2023 21:42
@katiehockman katiehockman requested a review from a team June 22, 2023 21:42
@pr-commenter
Copy link

pr-commenter bot commented Jun 22, 2023

Benchmarks

Benchmark execution time: 2023-06-27 19:01:25

Comparing candidate commit 027d923 in PR branch katie.hockman/otel-test with baseline commit 8dddd8b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@katiehockman katiehockman merged commit cf69fbb into main Jun 27, 2023
@katiehockman katiehockman deleted the katie.hockman/otel-test branch June 27, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants