Skip to content

ddtrace/tracer: changed default tracecontext propagation order #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 10, 2023
Merged

ddtrace/tracer: changed default tracecontext propagation order #2072

merged 9 commits into from
Jul 10, 2023
+42 −10

Conversation

dianashevchenko
Copy link
Contributor

@dianashevchenko dianashevchenko commented Jun 26, 2023 •
edited
Loading

What does this PR do?

Following the issues in serverless context propagation, this PR updates the propagation order to datadog

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@dianashevchenko dianashevchenko requested a review from a team June 26, 2023 13:27
@dianashevchenko dianashevchenko requested a review from a team as a code owner June 26, 2023 13:27
ahmed-mez
ahmed-mez reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just double checking, does the order matter in the extractor?

ahmed-mez
ahmed-mez reviewed Jun 26, 2023
View reviewed changes
@pr-commenter
Copy link

pr-commenter bot commented Jun 26, 2023 •
edited
Loading

Benchmarks

Benchmark execution time: 2023-07-07 14:39:03

Comparing candidate commit 6ed4f12 in PR branch shevchenko/context-propagation-order with baseline commit 46268f1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics.

@ahmed-mez
Copy link
Contributor

Summarizing what was discussed offline

  • It's not clear whether we want to change the order or just put datadog by default
  • The parametric tests must be implemented/fixed before making the change in the tracer

@dianashevchenko
Copy link
Contributor Author

Will close the PR for now

dianashevchenko and others added 3 commits June 30, 2023 10:49
@dianashevchenko
Merge branch 'main' into shevchenko/context-propagation-order
f99d960
@dianashevchenko
updated the tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fa2c631
@dianashevchenko
datadog propagator first
70851ee
@dianashevchenko dianashevchenko changed the title Changed default tracecontext propagation order ddtrace/tracer: changed default tracecontext propagation order Jun 30, 2023
@dianashevchenko dianashevchenko mentioned this pull request Jul 7, 2023
Merged
2 tasks
@dianashevchenko dianashevchenko merged commit eaa593d into main Jul 10, 2023
@dianashevchenko dianashevchenko deleted the shevchenko/context-propagation-order branch July 10, 2023 17:44
katiehockman added a commit that referenced this pull request Jul 24, 2023
@katiehockman
Revert "ddtrace/tracer: changed default tracecontext propagation order (
212245f 
#2072)"

This reverts commit eaa593d.
@katiehockman katiehockman mentioned this pull request Jul 24, 2023
Merged
knusbaum added a commit that referenced this pull request Jul 25, 2023
@knusbaum
Revert "ddtrace/tracer: changed default tracecontext propagation orde…
f159c03 
…r" (cherry-pick #2140) (#2144)

Cherry-pick of #2140

We do not want to change the default context propagation at this time.

Reverts #2072
@renovate renovate bot mentioned this pull request Aug 28, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed-mez ahmed-mez

@nsrip-dd nsrip-dd

@ajgajg1134 ajgajg1134

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dianashevchenko @ahmed-mez @ajgajg1134 @nsrip-dd