tracer: discard invalid _dd.p.tid in the datadog propagator #2076
+73
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_dd.p.tid
in thedatadog
propagator if the value isn't validtid
in thetracecontext
propagator: keep sending the malformedtid
seems to be the expected behavior in that case, based on the parametric tests_dd.propagation_error
tagMotivation
Enable test case
test_datadog_128_bit_propagation_tid_short
in parametric tests https://github.com/DataDog/system-tests/blob/main/tests/parametric/test_128_bit_traceids.py#L76Describe how to test/QA your changes
Unit tests + test case in parametric tests is enabled once this PR is merged
Reviewer's Checklist