Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer: discard invalid _dd.p.tid in the datadog propagator #2076

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Motivation

Enable test case test_datadog_128_bit_propagation_tid_short in parametric tests https://github.com/DataDog/system-tests/blob/main/tests/parametric/test_128_bit_traceids.py#L76

Describe how to test/QA your changes

Unit tests + test case in parametric tests is enabled once this PR is merged

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@ahmed-mez ahmed-mez requested review from a team and dianashevchenko June 26, 2023 16:59
@ahmed-mez ahmed-mez marked this pull request as draft June 26, 2023 17:26
@ahmed-mez ahmed-mez force-pushed the ahmed/tid-validation branch from 9c81c9a to bf31c4a Compare June 26, 2023 17:56
@pr-commenter
Copy link

pr-commenter bot commented Jun 26, 2023

Benchmarks

Benchmark execution time: 2023-06-27 09:59:13

Comparing candidate commit d183422 in PR branch ahmed/tid-validation with baseline commit 12ed8da in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@ahmed-mez ahmed-mez removed the request for review from dianashevchenko June 26, 2023 18:17
@ahmed-mez ahmed-mez force-pushed the ahmed/tid-validation branch from bf31c4a to fa4ac80 Compare June 26, 2023 18:38
@ahmed-mez ahmed-mez marked this pull request as ready for review June 26, 2023 18:52

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@ahmed-mez ahmed-mez force-pushed the ahmed/tid-validation branch from fa4ac80 to d183422 Compare June 27, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants