Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Simplify System Tests #2079

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

felixge
Copy link
Member

@felixge felixge commented Jun 27, 2023

What does this PR do?

  1. Reuse install_runner action from the system tests repo. This reduces code duplication.
  2. Use explicit build steps for runner, weblog and agent. This helps debugging performance.
  3. Update to checkout v3. This is just house keeping.

Motivation

Reduce duplication and make it easier to debug performance issues.

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

felixge added 3 commits June 27, 2023 08:54

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
fix

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2023

Benchmarks

Benchmark execution time: 2023-06-27 07:17:14

Comparing candidate commit aa698f5 in PR branch felix.geisendoerfer/ci-simplify-system-test with baseline commit 1170127 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@felixge felixge changed the title Use install_runner action CI: Simplify System Tests Jun 27, 2023
@felixge felixge marked this pull request as ready for review June 27, 2023 07:19
@felixge felixge requested a review from a team as a code owner June 27, 2023 07:19
@felixge felixge requested a review from cbeauchesne June 27, 2023 07:19
@felixge felixge merged commit 12ed8da into main Jun 27, 2023
@felixge felixge deleted the felix.geisendoerfer/ci-simplify-system-test branch June 27, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants