Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated instructions for adding a benchmark in contributing.md #2080

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

This PR updated CONTRIBUTING.md with up-to-date instructions on adding benchmarks to CI, since they have been moved to the benchmarking-platform repository.

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

@dianashevchenko dianashevchenko requested a review from a team as a code owner June 27, 2023 12:43
ahmed-mez
ahmed-mez previously approved these changes Jun 27, 2023
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2023

Benchmarks

Benchmark execution time: 2023-06-27 12:54:09

Comparing candidate commit 3e2461d in PR branch shevchenko/update-contrib-md with baseline commit 9b7defb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@ahmed-mez ahmed-mez merged commit b72b941 into main Jun 27, 2023
@ahmed-mez ahmed-mez deleted the shevchenko/update-contrib-md branch June 27, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants