internal/appsec: remove unnecessary remoteconfig updates specifications #2084
+37
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hellzy
force-pushed
the
francois.mazeau/exclusion-filters-fix
branch
from
76a6fdf to
370186b
Compare
BenchmarksBenchmark execution time: 2023-06-29 09:19:21 Comparing candidate commit 20e39ec in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics. |
|
System-tests with exclusion filters enabled: https://github.com/DataDog/dd-trace-go/actions/runs/5402817090 |
Julio-Guerra
previously approved these changes
Jun 28, 2023
Hellzy
force-pushed
the
francois.mazeau/exclusion-filters-fix
branch
from
43ed772 to
cf0b8f7
Compare
Hellzy
changed the title
Julio-Guerra
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
This specification was wrong and resulted in wrongly encoded exclusion filters, rendering them void to use by the WAF.
Simplifying the specification (by using
interface{}) allows to remain flexible in case of spec change as well as preventingspecification mistakes (such as the one we spotted) on our side.
Describe how to test/QA your changes
Reviewer's Checklist