Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: Reduce execution trace period to 15min #2091

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

felixge
Copy link
Member

@felixge felixge commented Jul 4, 2023

The initial value was very conservative, especially considering that this feature is opt-in for now. We expect this new value to be a better tradeoff between overhead, data volumes and span coverage.

What does this PR do?

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
The initial value was very conservative, especially considering that
this feature is opt-in for now. We expect this new value to be a better
tradeoff between overhead, data volumes and span coverage.
@felixge felixge requested a review from a team as a code owner July 4, 2023 07:31
@felixge felixge requested a review from nsrip-dd July 4, 2023 07:31
@pr-commenter
Copy link

pr-commenter bot commented Jul 4, 2023

Benchmarks

Benchmark execution time: 2023-07-04 07:41:11

Comparing candidate commit 7a41f17 in PR branch felix.geisendoerfer/PROF-7904-increase-interval with baseline commit 2c7a8f4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics.

@felixge felixge merged commit c10c902 into main Jul 5, 2023
@felixge felixge deleted the felix.geisendoerfer/PROF-7904-increase-interval branch July 5, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants