Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/emicklei/go-restful.v3: move to the correct folder #2092

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jul 4, 2023

What does this PR do?

Move integration contrib/emicklei/go-restful/v3 (that was added in #2088) to the correct folder

contrib/emicklei/go-restful/v3 => contrib/emicklei/go-restful.v3

Motivation

Follow codebase standards.

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@rarguelloF rarguelloF marked this pull request as ready for review July 4, 2023 08:31
@rarguelloF rarguelloF requested a review from a team July 4, 2023 08:31
@pr-commenter
Copy link

pr-commenter bot commented Jul 4, 2023

Benchmarks

Benchmark execution time: 2023-07-06 10:53:58

Comparing candidate commit e63a324 in PR branch rarguelloF/fix-go-restful-path with baseline commit 2eee7a0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics.

katiehockman and others added 2 commits July 5, 2023 09:42

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@rarguelloF rarguelloF merged commit f0e9c3f into main Jul 6, 2023
@rarguelloF rarguelloF deleted the rarguelloF/fix-go-restful-path branch July 6, 2023 11:41
knusbaum pushed a commit that referenced this pull request Jul 20, 2023

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
After #2092, where the integration was moved to the correct folder, I forgot to update the componentName as well.
knusbaum pushed a commit that referenced this pull request Jul 20, 2023

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
After #2092, where the integration was moved to the correct folder, I forgot to update the componentName as well.
knusbaum added a commit that referenced this pull request Jul 20, 2023
…#2136)

After #2092, where the integration was moved to the correct folder, I forgot to update the componentName as well.

This is a cherry-pick of #2132 onto the v1.53.x release branch.
katiehockman pushed a commit that referenced this pull request Jul 26, 2023
After #2092, where the integration was moved to the correct folder, I forgot to update the componentName as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants