ddtrace/tracer: do not fallback to target host as Cassandra peer.service source #2100
+27
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkalmakis
reviewed
Jul 6, 2023
BenchmarksBenchmark execution time: 2023-07-11 08:56:23 Comparing candidate commit 0711ca1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics. |
pkalmakis
approved these changes
Jul 10, 2023
knusbaum
approved these changes
Jul 10, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not fallback to use target host tags as peer.service source for Cassandra spans when
db.cassandra.contact.pointsis missing.Motivation
For users who cannot migrate to the tracing methods added in #2057 and get the correct peer.service source for Cassandra (
db.cassandra.contact.points), it's better to not have a peer.service rather thanout.host(or equivalent tags).Describe how to test/QA your changes
Reviewer's Checklist