Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/gocql: add WithCustomTag option #2105

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jul 10, 2023

What does this PR do?

Adds WithCustomTag option to gocql.

Motivation

Allow users to set custom tags.

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@rarguelloF rarguelloF marked this pull request as ready for review July 10, 2023 16:06
@rarguelloF rarguelloF requested a review from a team July 10, 2023 16:06
@pr-commenter
Copy link

pr-commenter bot commented Jul 10, 2023

Benchmarks

Benchmark execution time: 2023-07-10 20:11:20

Comparing candidate commit 3bfe024 in PR branch rarguelloF/gocql-with-custom-tag with baseline commit eaa593d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics.

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@rarguelloF rarguelloF merged commit 60cbd27 into main Jul 11, 2023
@rarguelloF rarguelloF deleted the rarguelloF/gocql-with-custom-tag branch July 11, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants