-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/internal/httptrace: improve performance of span starts #2128
Merged
+46
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the performance of starting a span by reducing work done, especially allocations.
|
knusbaum
commented
Jul 19, 2023
knusbaum
commented
Jul 19, 2023
ajgajg1134
reviewed
Jul 19, 2023
BenchmarksBenchmark execution time: 2023-07-19 19:53:56 Comparing candidate commit c65db5c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics. |
ajgajg1134
approved these changes
Jul 19, 2023
New benchstat output:
|
knusbaum
added a commit
that referenced
this pull request
Jul 20, 2023
This commit improves the performance of starting a span by reducing work done, especially allocations.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit improves the performance of starting a span by reducing work
done, especially allocations.
Motivation
We were seeing a large increase in memory and CPU usage while starting spans compared to previous versions.
Describe how to test/QA your changes
Reviewer's Checklist