contrib/labstack/echo.v4: add WithErrorTranslator Option #2169
+69
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ahmed-mez , if there is anything I can do to expedite this PR, let me know! |
|
Hey @mattscamp - thanks for the contribution! The PR is triaged and the corresponding team will review in the coming days. |
djjackson
approved these changes
Aug 24, 2023
rarguelloF
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
zarirhamza
approved these changes
Aug 31, 2023
rarguelloF
reviewed
Aug 31, 2023
There was a problem hiding this comment.
Thanks for the contribution! @mattscamp
After reviewing with @zarirhamza, we just came up with a few minor changes to simplify the code a little bit and make the name of the option a little bit more descriptive. Once these few changes are made, it should be good to go.
|
Thanks @rarguelloF @zarirhamza - made those suggested updates! |
mattscamp
changed the title
rarguelloF
approved these changes
Sep 7, 2023
ajgajg1134
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
WithErrorTranslatorOption that allows defining a translator of custom errors to the required format.Motivation
We use a custom error type across our company that cannot be translated to an
echo.HTTPErrorwhich results in all our status codes set as 500.Reviewer's Checklist