Skip to content

datastreams: Add version tag #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

piochelepiotr
Copy link
Collaborator

What does this PR do?

Add a version tag to stats produced for data streams monitoring.
This will help detect when deployments happen.

Motivation

When there is a sudden increase in latency, it is useful to understand if it's due to a new version being rolled out.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@piochelepiotr piochelepiotr requested a review from a team as a code owner September 7, 2023 14:14
@piochelepiotr piochelepiotr requested a review from a team September 7, 2023 14:14
@pr-commenter
Copy link

pr-commenter bot commented Sep 7, 2023

Benchmarks

Benchmark execution time: 2023-09-11 17:54:07

Comparing candidate commit e851c2f in PR branch piotr-wolski/add-version-tag with baseline commit 43a4d91 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@katiehockman katiehockman merged commit 246238d into main Sep 11, 2023
@katiehockman katiehockman deleted the piotr-wolski/add-version-tag branch September 11, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants