-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiler: add go_num_goroutine metric #2217
profiler: add go_num_goroutine metric #2217
Conversation
Create a field to wrap runtime.MemStats. This will allow capturing other metrics coming from different places more easily.
BenchmarksBenchmark execution time: 2023-09-15 10:04:09 Comparing candidate commit 1ee2035 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! If you'd like, we can wait until the backend changes are deployed to validate this using the unit-of-work app from this PR? I don't feel strongly about that, though. Up to you :)
I think we should merge it. We can manually kick off a test-app run on main once the backend changes are ready. Also, let's try out this new merge queue thing, I've been told it's working now. |
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 0s) you can cancel this operation by commenting your pull request with |
🚨 MergeQueue not able to merge the branch in the target branch Details
Error: PUT https://api.github.com/repos/DataDog/dd-trace-go/pulls/2217/merge: 405 5 of 5 required status checks are expected. You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information. [] FullStacktrace: If you need support, contact us on slack #ci-interfaces with those details! |
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 0s) you can cancel this operation by commenting your pull request with |
🚨 MergeQueue not able to merge the branch in the target branch Details
Error: PUT https://api.github.com/repos/DataDog/dd-trace-go/pulls/2217/merge: 405 5 of 5 required status checks are expected. [] FullStacktrace: If you need support, contact us on slack #ci-interfaces with those details! |
/merge |
🚨 MergeQueue You are not allowed to use the merge queue towards If you need support, contact us on slack #ci-interfaces with those details! |
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 0s) you can cancel this operation by commenting your pull request with |
What does this PR do?
Add a new metric capturing the number of active goroutines. See commit messages for details.
Motivation
This will help users to investigate goroutine leaks.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!