Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer: verify that hostname reporting is honored regardless of stats calculation #2533

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

katiehockman
Copy link
Contributor

What does this PR do?

Expands the current tests to verify that regardless of the value of DD_TRACE_COMPUTE_STATS, the DD_TRACE_REPORT_HOSTNAME variable is always respected.

Motivation

This is important to prevent an unintentional cardinality increase when tracer stats are enabled, and would maintain inheritance of host tags.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@katiehockman katiehockman marked this pull request as ready for review January 30, 2024 19:13
@katiehockman katiehockman requested a review from a team as a code owner January 30, 2024 19:13
@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2024

Benchmarks

Benchmark execution time: 2024-01-30 19:27:49

Comparing candidate commit 96078f1 in PR branch katie.hockman/stats-test with baseline commit 8c4834f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@katiehockman katiehockman merged commit e707cc9 into main Jan 31, 2024
@katiehockman katiehockman deleted the katie.hockman/stats-test branch January 31, 2024 15:58
darccio pushed a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants