contrib/google.golang.org/api: update grpc contrib to work with API changes. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metadata API changes. Google's metadata API has changed, and so our grpc.v12 contrib no longer compiles. This commit updates the grpc.v12 contrib package to use the new API.
knusbaum
force-pushed
the
knusbaum/grpc-lib-fix
branch
from
7758ae5
to
99515ef
Compare
knusbaum
changed the title
|
I had a misunderstanding about what the issue was. Working now on resolving it. |
|
This is not something we can fix, but it looks like grpc is fixing it now. grpc deleted an API in grpc/grpc-go#3301 The change caused google.golang.org to stop compiling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google's grpc API has changed, and so our contrib no longer compiles.
This commit updates the contrib package to use the new API.