Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add synchronous scope manager.
Motivation
Because of the issue with
async_hooks
, there are cases where it's not possible to track the asynchronous context. However, our auto-instrumentation expects to always be able to get the parent span from the scope manager, which makes the it unusable when scope management is completely disabled. This new scope manager works around this issue by allowing to manually re-activate a span on a synchronous scope to make it available when the integration starts its own span.For example:
While the
async_hooks
issue should be fixed in a few months, in the meantime this allows to continue using auto-instrumentation by manually connecting spans from integrations together. The code is extremely simple so it also doesn't add unnecessary maintenance overhead after the fix will have landed.