Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.35.1 #3219

Merged
merged 8 commits into from
Jun 8, 2023
Merged

v2.35.1 #3219

merged 8 commits into from
Jun 8, 2023

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Jun 7, 2023

Bug Fixes

Improvements

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Overall package size

Self size: 4.25 MB
Deduped: 68.78 MB
No deduping: 68.82 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/native-metrics 1.6.0 7.88 MB 7.89 MB
protobufjs 7.2.3 2.77 MB 6.65 MB
@types/node 18.11.19 3.58 MB 3.58 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
opentracing 0.14.7 194.81 kB 194.81 kB
lru-cache 7.18.3 133.92 kB 133.92 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.4 51.22 kB 51.22 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #3219 (80557c9) into v2.x (fbc2899) will decrease coverage by 7.50%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             v2.x    #3219      +/-   ##
==========================================
- Coverage   93.51%   86.01%   -7.50%     
==========================================
  Files         222      184      -38     
  Lines        8829     7403    -1426     
  Branches        0       33      +33     
==========================================
- Hits         8256     6368    -1888     
- Misses        573     1035     +462     
Impacted Files Coverage Δ
integration-tests/ci-visibility/test/sum.js 69.19% <ø> (ø)
packages/datadog-instrumentations/src/mocha.js 0.00% <0.00%> (-98.64%) ⬇️
packages/datadog-plugin-fastify/src/index.js 100.00% <ø> (ø)

... and 298 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jun 7, 2023

Benchmarks

Comparing candidate commit 80557c9 in PR branch v2.35.1-proposal with baseline commit ef38c1a in branch v2.x.

Found 0 performance improvements and 10 performance regressions! Performance is the same for 652 metrics, 46 unstable metrics.

scenario:startup-control-everything-14

  • 🟥 instructions [+0; +0] or [+5.689%; +6.468%]

scenario:startup-with-tracer-everything-14

  • 🟥 instructions [+0; +0] or [+5.488%; +5.798%]

scenario:startup-control-everything-16

  • 🟥 instructions [+0; +0] or [+5.687%; +6.195%]

scenario:startup-with-tracer-everything-16

  • 🟥 instructions [+0; +0] or [+5.780%; +6.223%]

scenario:startup-control-everything-18

  • 🟥 cpu_user_time [+0.070s; +0.087s] or [+5.896%; +7.287%]
  • 🟥 execution_time [+0.093s; +0.104s] or [+6.932%; +7.725%]
  • 🟥 instructions [+0; +0] or [+6.239%; +6.818%]

scenario:startup-with-tracer-everything-18

  • 🟥 cpu_user_time [+0.083s; +0.103s] or [+5.272%; +6.573%]
  • 🟥 execution_time [+0.111s; +0.114s] or [+6.252%; +6.427%]
  • 🟥 instructions [+0; +0] or [+6.358%; +6.622%]

wconti27 and others added 8 commits June 7, 2023 16:02
* Add Datadog APM Test Agent to handle all plugin test traces
Co-authored-by: Dominik Krejcik <dominik.krejcik@gmail.com>
…bles (#3055)

* Include send-data missing headers

* Rename DD_TELEMETRY_DEBUG_ENABLED as DD_TELEMETRY_DIAGNOSTIC_LOG_COLLECTION_ENABLED

* Move DD_TELEMETRY_HEARTBEAT_INTERVAL to config.js

* Remove DD_TELEMETRY_DIAGNOSTIC_LOG_COLLECTION_ENABLED
* Add ability to create and publish .deb and .rpm packages

* only look at version tags

* add verbose flag
- previously, when encountering a dead code path that requires a not-installed instrumented package, build would fail
  - this would happen when, say, `knex` requires the `tedious` library for an app that is only making use of `pg`
  - without `dd-trace/esbuild`, a user simply adds `tedious` to their `external` list and goes on with their day
  - or in other words, vanilla esbuild doesn't really care when it encounters these missing modules
  - with `dd-trace/esbuild`, we would throw an error and the build fails
- one solution would be to not instrument external packages but many users expect this behavior to work
  - in fact, we've been telling users to do just this before we supported a plugin
- now, with this change, the `require('unused-module')` call remains in the output code
  - print a warning when this happens (at build time), regardless of debug level, since it might not be intentional
* Fix OracleDB plugin job on CI to use Github Actions services container for Test-Agent instead of docker-compose
@tlhunter tlhunter marked this pull request as ready for review June 7, 2023 23:34
@tlhunter tlhunter requested review from a team as code owners June 7, 2023 23:34
@tlhunter tlhunter merged commit d484219 into v2.x Jun 8, 2023
111 checks passed
@tlhunter tlhunter deleted the v2.35.1-proposal branch December 19, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants