Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.1.1 #3221

Merged
merged 8 commits into from
Jun 8, 2023
Merged

v4.1.1 #3221

merged 8 commits into from
Jun 8, 2023

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Jun 7, 2023

Bug Fixes

Improvements

wconti27 and others added 7 commits June 7, 2023 15:00
* Add Datadog APM Test Agent to handle all plugin test traces
Co-authored-by: Dominik Krejcik <dominik.krejcik@gmail.com>
…bles (#3055)

* Include send-data missing headers

* Rename DD_TELEMETRY_DEBUG_ENABLED as DD_TELEMETRY_DIAGNOSTIC_LOG_COLLECTION_ENABLED

* Move DD_TELEMETRY_HEARTBEAT_INTERVAL to config.js

* Remove DD_TELEMETRY_DIAGNOSTIC_LOG_COLLECTION_ENABLED
* Add ability to create and publish .deb and .rpm packages

* only look at version tags

* add verbose flag
- previously, when encountering a dead code path that requires a not-installed instrumented package, build would fail
  - this would happen when, say, `knex` requires the `tedious` library for an app that is only making use of `pg`
  - without `dd-trace/esbuild`, a user simply adds `tedious` to their `external` list and goes on with their day
  - or in other words, vanilla esbuild doesn't really care when it encounters these missing modules
  - with `dd-trace/esbuild`, we would throw an error and the build fails
- one solution would be to not instrument external packages but many users expect this behavior to work
  - in fact, we've been telling users to do just this before we supported a plugin
- now, with this change, the `require('unused-module')` call remains in the output code
  - print a warning when this happens (at build time), regardless of debug level, since it might not be intentional
* Fix OracleDB plugin job on CI to use Github Actions services container for Test-Agent instead of docker-compose
@tlhunter tlhunter changed the base branch from master to v4.x June 7, 2023 22:03
@pr-commenter
Copy link

pr-commenter bot commented Jun 7, 2023

Benchmarks

Comparing candidate commit 30ff2f9 in PR branch v4.1.1-proposal with baseline commit c1b80aa in branch v4.x.

Found 0 performance improvements and 8 performance regressions! Performance is the same for 434 metrics, 30 unstable metrics.

scenario:startup-control-everything-16

  • 🟥 instructions [+0; +0] or [+5.698%; +6.324%]

scenario:startup-with-tracer-everything-16

  • 🟥 instructions [+0; +0] or [+5.638%; +6.039%]

scenario:startup-control-everything-18

  • 🟥 cpu_user_time [+0.082s; +0.104s] or [+6.719%; +8.502%]
  • 🟥 execution_time [+0.097s; +0.112s] or [+6.927%; +8.025%]
  • 🟥 instructions [+0; +0] or [+5.837%; +6.273%]

scenario:startup-with-tracer-everything-18

  • 🟥 cpu_user_time [+0.085s; +0.102s] or [+5.844%; +7.014%]
  • 🟥 execution_time [+0.102s; +0.116s] or [+6.086%; +6.933%]
  • 🟥 instructions [+0; +0] or [+6.181%; +6.430%]

Copy link
Collaborator

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 4.x, though the corresponding 2.x and 3.x proposal PRs seem to have some failures. Should probably sort those before landing this. 🤔

@tlhunter tlhunter marked this pull request as ready for review June 7, 2023 23:34
@tlhunter tlhunter requested review from a team as code owners June 7, 2023 23:34
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Overall package size

Self size: 4.25 MB
Deduped: 58.45 MB
No deduping: 58.49 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.4.1 14.85 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v4.x@c1b80aa). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v4.x    #3221   +/-   ##
=======================================
  Coverage        ?   85.76%           
=======================================
  Files           ?      182           
  Lines           ?     7229           
  Branches        ?       33           
=======================================
  Hits            ?     6200           
  Misses          ?     1029           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlhunter tlhunter merged commit 313f613 into v4.x Jun 8, 2023
102 checks passed
@tlhunter tlhunter deleted the v4.1.1-proposal branch December 19, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants