add remote config support for sampling rules #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 6.59 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-05-30 22:58:57 Comparing candidate commit 83a26ee in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 264 metrics, 2 unstable metrics. |
rochdev
previously requested changes
Apr 19, 2024
ida613
changed the title
simon-id
reviewed
May 15, 2024
simon-id
requested changes
May 15, 2024
…e-js into ida613/rc-sampling-rules
simon-id
reviewed
May 16, 2024
simon-id
reviewed
May 17, 2024
Co-authored-by: simon-id <simon.id@datadoghq.com>
simon-id
reviewed
May 17, 2024
simon-id
previously approved these changes
May 17, 2024
…e-js into ida613/rc-sampling-rules
ida613
changed the title
bengl
approved these changes
May 31, 2024
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 4, 2024
* added rc support for sampling rules * run system test * Update config.spec.js * add rc capability and update code styling * removed unnessary check * add unit test * unit test fix * fix lint errors * fix lint error * Update packages/dd-trace/test/config.spec.js Co-authored-by: simon-id <simon.id@datadoghq.com> * simplified code * ignore sampling rules tags for now * fix lint errors * remove unnecessary comments and ci command --------- Co-authored-by: simon-id <simon.id@datadoghq.com>
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 4, 2024
* added rc support for sampling rules * run system test * Update config.spec.js * add rc capability and update code styling * removed unnessary check * add unit test * unit test fix * fix lint errors * fix lint error * Update packages/dd-trace/test/config.spec.js Co-authored-by: simon-id <simon.id@datadoghq.com> * simplified code * ignore sampling rules tags for now * fix lint errors * remove unnecessary comments and ci command --------- Co-authored-by: simon-id <simon.id@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://docs.google.com/document/d/12lXVniuaYenanxnpt5gJJ76a1X7gFOfmCYVQVXlHNco/edit?usp=sharing
forcing system test to run with changes in .github/workflows/system-tests.yml, will delete the change after PR passes review
Motivation
Plugin Checklist
Additional Notes