Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't clobber manually-installed tracer with SSI #4300

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented May 14, 2024

What does this PR do?

Stops SSI-installed tracer from clobbering manually-installed tracer.

Motivation

A manually-installed tracer shouldn't be interfered with by SSI.

@bengl bengl requested a review from a team as a code owner May 14, 2024 04:10
Copy link

github-actions bot commented May 14, 2024

Overall package size

Self size: 6.48 MB
Deduped: 60.19 MB
No deduping: 60.47 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@bengl bengl changed the title don\'t clobber manually-installed tracer with SSI don't clobber manually-installed tracer with SSI May 14, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 14, 2024

Benchmarks

Benchmark execution time: 2024-05-16 17:41:16

Comparing candidate commit 050cd1b in PR branch bengl/no-ssi-clobber with baseline commit 12d02ee in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

@bengl bengl force-pushed the bengl/no-ssi-clobber branch 2 times, most recently from 6946228 to 93a55ac Compare May 14, 2024 04:27
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (59cb67b) to head (050cd1b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4300      +/-   ##
==========================================
+ Coverage   86.09%   87.07%   +0.97%     
==========================================
  Files         245      245              
  Lines       10345    10343       -2     
  Branches       33       33              
==========================================
+ Hits         8907     9006      +99     
+ Misses       1438     1337     -101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Qard
Qard previously approved these changes May 14, 2024
init.js Show resolved Hide resolved
init.js Show resolved Hide resolved
init.js Outdated Show resolved Hide resolved
@bengl bengl enabled auto-merge (squash) May 16, 2024 17:34
@bengl bengl merged commit 8700d09 into master May 16, 2024
109 of 112 checks passed
@bengl bengl deleted the bengl/no-ssi-clobber branch May 16, 2024 18:11
This was referenced May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants