Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiler support for node 22 #4312

Merged
merged 1 commit into from
May 16, 2024

Conversation

nsavoire
Copy link
Collaborator

What does this PR do?

Update pprof-nodejs to 5.3.0 and run profiling and tracing tests on latest nodejs.

Motivation

Add support for profiling on node 22.

pprof-nodejs 5.3.0 adds support for node 22.
Reenable profiling and tracing tests on node latest.
Copy link

Overall package size

Self size: 6.47 MB
Deduped: 60.18 MB
No deduping: 60.46 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented May 16, 2024

Benchmarks

Benchmark execution time: 2024-05-16 09:53:52

Comparing candidate commit 74cabc0 in PR branch nsavoire/PROF-9780_add_profiler_node22_support with baseline commit 5d29b40 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 264 metrics, 2 unstable metrics.

@@ -34,7 +34,7 @@ jobs:
- uses: ./.github/actions/node/20
- run: yarn test:profiler:ci
- run: yarn test:integration:profiler
- uses: ./.github/actions/node/21
- uses: ./.github/actions/node/latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have something for 21 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd numbered versions are not LTS, and we do not test them except when they are latest

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd numbers go EOL to moment the next even numbered release happens, so we don't consider them supported at all, but we test against them because it can, to some extent, warn us ahead of time when an issue is coming. Generally more significant breaking changes are saved for odd releases so there's time to test them in userland and revert in the next even release. While even releases tend to only take more conservative breaking changes due to being harder to undo before it becomes LTS.

@nsavoire nsavoire merged commit 59cb67b into master May 16, 2024
112 of 114 checks passed
@nsavoire nsavoire deleted the nsavoire/PROF-9780_add_profiler_node22_support branch May 16, 2024 15:32
khanayan123 pushed a commit that referenced this pull request May 16, 2024
pprof-nodejs 5.3.0 adds support for node 22.
Reenable profiling and tracing tests on node latest.
khanayan123 pushed a commit that referenced this pull request May 16, 2024
pprof-nodejs 5.3.0 adds support for node 22.
Reenable profiling and tracing tests on node latest.
This was referenced May 16, 2024
khanayan123 pushed a commit that referenced this pull request May 17, 2024
pprof-nodejs 5.3.0 adds support for node 22.
Reenable profiling and tracing tests on node latest.
khanayan123 pushed a commit that referenced this pull request May 17, 2024
pprof-nodejs 5.3.0 adds support for node 22.
Reenable profiling and tracing tests on node latest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants