Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): native extensions are no longer optional on supported platforms #9169

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented May 6, 2024

WIP

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: sanchda/less_permissive_builds
Commit report: 4dcd235
Test service: dd-trace-py

✅ 0 Failed, 173837 Passed, 1149 Skipped, 11h 25m 1.6s Total duration (8m 4s time saved)
⌛ 2 Performance Regressions

⌛ Performance Regressions vs Default Branch (2)

  • test_file_delete[False] - test_openai_v1.py 3.07s (+2.56s, +510%) - Details
  • test_export_server_down - test_http.py 5.82s (+4.79s, +464%) - Details

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.65%. Comparing base (9e862f9) to head (4dcd235).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9169       +/-   ##
===========================================
- Coverage   78.56%    6.65%   -71.91%     
===========================================
  Files        1274     1244       -30     
  Lines      120349   118569     -1780     
===========================================
- Hits        94547     7886    -86661     
- Misses      25802   110683    +84881     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants