chore(profiling): pin version of echion dependency [backport 2.7] #9177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
changelog/no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 522 Passed, 540 Skipped, 9m 7.95s Wall Time |
BenchmarksBenchmark execution time: 2024-05-07 18:35:58 Comparing candidate commit e673806 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 200 metrics, 9 unstable metrics. scenario:httppropagationextract-datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match
|
sanchda
approved these changes
May 7, 2024
brettlangdon
approved these changes
May 7, 2024
Profiling introduced a "stack v2" feature recently in order to address reports of segmentation faults. As part of this, we rely on the [echion](https://github.com/P403n1x87/echion) codebase. We'll be making changes to echion in response to certain customer issues, with the corresponding fixes needing to be backported. This PR simply tightens up the build process for stack v2 in order to pin the dependency version more precisely. It's a developmental PR for future fixups. ## Checklist - [X] Change(s) are motivated and described in the PR description - [X] Testing strategy is described if automated tests are not included in the PR - [X] Risks are described (performance impact, potential for breakage, maintainability) - [X] Change is maintainable (easy to change, telemetry, documentation) - [X] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [X] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [X] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [X] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [ ] Title is accurate - [ ] All changes are related to the pull request's stated goal - [ ] Description motivates each change - [ ] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [ ] Testing strategy adequately addresses listed risks - [ ] Change is maintainable (easy to change, telemetry, documentation) - [ ] Release note makes sense to a user of the library - [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [ ] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: sanchda <sanchda@users.noreply.github.com> (cherry picked from commit b860ab0)
brettlangdon
force-pushed
the
backport-9142-to-2.7
branch
from
ea44324
to
e673806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b860ab0 from #9142 to 2.7.
Profiling introduced a "stack v2" feature recently in order to address reports of segmentation faults.
As part of this, we rely on the echion codebase. We'll be making changes to echion in response to certain customer issues, with the corresponding fixes needing to be backported.
This PR simply tightens up the build process for stack v2 in order to pin the dependency version more precisely. It's a developmental PR for future fixups.
Checklist
changelog/no-changelogis set@DataDog/apm-tees.Reviewer Checklist