Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asm): ASM support for GRPC #9185

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented May 7, 2024

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 7, 2024

Datadog Report

Branch report: gnufede/APPSEC-52949-grpcio-threats-monitoring-support
Commit report: 2b98344
Test service: dd-trace-py

❌ 1 Failed (1 Known Flaky), 131666 Passed, 39138 Skipped, 3h 45m 6.58s Total duration (5h 6m 1.78s time saved)

❌ Failed Tests (1)

  • test_openai_sequential_chain - test_langchain_community.py - ❄️ Known flaky - Details

    Expand for error
     At request <Request GET /test/session/snapshot >:
        At snapshot (token='tests.contrib.langchain.test_langchain_community.test_openai_sequential_chain'):
         - Directory: /snapshots
         - CI mode: 1
         - Trace File: /snapshots/tests.contrib.langchain.test_langchain_community.test_openai_sequential_chain.json
         - Stats File: /snapshots/tests.contrib.langchain.test_langchain_community.test_openai_sequential_chain_tracestats.json
         At compare of 1 expected trace(s) to 1 received trace(s):
          At trace 'langchain.request' (4 spans):
           At snapshot compare of span 'langchain.request' at position 1 in trace:
            - Expected span:
     ...
    

@pr-commenter
Copy link

pr-commenter bot commented May 8, 2024

Benchmarks

Benchmark execution time: 2024-05-08 11:39:19

Comparing candidate commit 891e112 in PR branch gnufede/APPSEC-52949-grpcio-threats-monitoring-support with baseline commit 2230214 in branch main.

Found 15 performance improvements and 11 performance regressions! Performance is the same for 183 metrics, 9 unstable metrics.

scenario:coreapiscenario-context_with_data_only_all_listeners

  • 🟩 max_rss_usage [-731.480KB; -589.890KB] or [-3.410%; -2.750%]

scenario:coreapiscenario-core_dispatch_listeners_and_all_listeners

  • 🟩 max_rss_usage [-598.493KB; -546.339KB] or [-2.785%; -2.542%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • 🟩 max_rss_usage [-727.525KB; -588.520KB] or [-3.392%; -2.744%]

scenario:coreapiscenario-core_dispatch_with_results_listeners_and_all_listeners

  • 🟩 max_rss_usage [-708.874KB; -656.732KB] or [-3.301%; -3.058%]

scenario:httppropagationextract-empty_headers

  • 🟩 max_rss_usage [-756.910KB; -702.904KB] or [-3.531%; -3.279%]

scenario:httppropagationextract-full_t_id_datadog_headers

  • 🟥 max_rss_usage [+770.647KB; +1099.996KB] or [+3.765%; +5.375%]

scenario:httppropagationextract-large_header_no_matches

  • 🟩 max_rss_usage [-833.753KB; -471.233KB] or [-3.982%; -2.251%]

scenario:httppropagationextract-none_propagation_style

  • 🟥 max_rss_usage [+420.625KB; +809.403KB] or [+2.045%; +3.935%]

scenario:httppropagationextract-tracecontext_headers

  • 🟥 max_rss_usage [+477.988KB; +792.592KB] or [+2.326%; +3.857%]

scenario:httppropagationextract-wsgi_invalid_trace_id_header

  • 🟥 max_rss_usage [+514.693KB; +905.799KB] or [+2.481%; +4.365%]

scenario:httppropagationextract-wsgi_large_valid_headers_all

  • 🟥 max_rss_usage [+617.915KB; +767.761KB] or [+2.972%; +3.693%]

scenario:httppropagationextract-wsgi_medium_valid_headers_all

  • 🟥 max_rss_usage [+705.048KB; +761.320KB] or [+3.399%; +3.670%]

scenario:httppropagationinject-ids_only

  • 🟥 max_rss_usage [+625.402KB; +725.869KB] or [+3.017%; +3.501%]

scenario:httppropagationinject-with_tags_invalid

  • 🟩 max_rss_usage [-967.385KB; -784.884KB] or [-4.523%; -3.670%]

scenario:httppropagationinject-with_tags_max_size

  • 🟩 max_rss_usage [-973.934KB; -933.164KB] or [-4.540%; -4.350%]

scenario:iastpropagation-no-propagation

  • 🟩 max_rss_usage [-629.637KB; -562.709KB] or [-2.793%; -2.496%]

scenario:otelspan-start-finish

  • 🟩 max_rss_usage [-733.174KB; -681.994KB] or [-3.237%; -3.011%]

scenario:otelspan-start-finish-telemetry

  • 🟩 max_rss_usage [-741.786KB; -665.190KB] or [-3.259%; -2.922%]

scenario:sethttpmeta-obfuscation-send-querystring-disabled

  • 🟩 max_rss_usage [-702.780KB; -652.177KB] or [-3.198%; -2.967%]

scenario:sethttpmeta-obfuscation-worst-case-implicit-query

  • 🟩 max_rss_usage [-719.354KB; -665.094KB] or [-3.274%; -3.027%]

scenario:sethttpmeta-useragentvariant_exists_2

  • 🟥 max_rss_usage [+956.504KB; +1009.166KB] or [+4.604%; +4.858%]

scenario:sethttpmeta-useragentvariant_exists_3

  • 🟥 max_rss_usage [+943.813KB; +998.919KB] or [+4.541%; +4.806%]

scenario:span-add-tags

  • 🟥 max_rss_usage [+807.768KB; +1076.802KB] or [+2.683%; +3.576%]

scenario:span-start-finish

  • 🟥 max_rss_usage [+502.534KB; +700.871KB] or [+2.413%; +3.366%]

scenario:tracer-large

  • 🟩 max_rss_usage [-781.033KB; -711.140KB] or [-3.444%; -3.136%]

scenario:tracer-small

  • 🟩 max_rss_usage [-765.541KB; -685.263KB] or [-3.543%; -3.171%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants