Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asm): add SSRF support for webbrowser.open #9209

Merged
merged 37 commits into from May 13, 2024
Merged

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented May 9, 2024

Description

Add SSRF taint sink support for the stdlib webbrowser module.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels May 9, 2024
@juanjux juanjux self-assigned this May 9, 2024
juanjux and others added 5 commits May 9, 2024 13:40
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@pr-commenter
Copy link

pr-commenter bot commented May 9, 2024

Benchmarks

Benchmark execution time: 2024-05-13 11:43:15

Comparing candidate commit 6b0e9f6 in PR branch juanjux/webbrowser-ssrf with baseline commit fccb8b3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@juanjux juanjux marked this pull request as ready for review May 9, 2024 17:27
@juanjux juanjux requested review from a team as code owners May 9, 2024 17:27
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 10, 2024

Datadog Report

Branch report: juanjux/webbrowser-ssrf
Commit report: 6b0e9f6
Test service: dd-trace-py

✅ 0 Failed, 115668 Passed, 59727 Skipped, 2h 50m 41.64s Total duration (7h 29m 30.66s time saved)

avara1986 and others added 5 commits May 10, 2024 12:27
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 142 lines in your changes are missing coverage. Please review.

Project coverage is 6.77%. Comparing base (60be242) to head (6b0e9f6).
Report is 1 commits behind head on main.

Files Patch % Lines
tests/appsec/iast/taint_sinks/test_ssrf.py 0.00% 102 Missing ⚠️
ddtrace/contrib/webbrowser/patch.py 0.00% 21 Missing ⚠️
ddtrace/appsec/_iast/taint_sinks/ssrf.py 0.00% 15 Missing ⚠️
ddtrace/contrib/webbrowser/__init__.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9209       +/-   ##
===========================================
- Coverage   78.58%    6.77%   -71.82%     
===========================================
  Files        1277     1249       -28     
  Lines      120432   118747     -1685     
===========================================
- Hits        94646     8045    -86601     
- Misses      25786   110702    +84916     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux enabled auto-merge (squash) May 10, 2024 19:51
juanjux and others added 3 commits May 10, 2024 22:13
@juanjux juanjux requested a review from brettlangdon May 13, 2024 09:55
@juanjux juanjux merged commit 78f361a into main May 13, 2024
204 checks passed
@juanjux juanjux deleted the juanjux/webbrowser-ssrf branch May 13, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants