Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): remove flaky telemetry tests #9213

Merged
merged 10 commits into from May 13, 2024

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented May 9, 2024

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels May 9, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 9, 2024

Datadog Report

Branch report: avara1986/remove_telemetry_flaky_tests
Commit report: bca184f
Test service: dd-trace-py

✅ 0 Failed, 1614 Passed, 2147 Skipped, 39m 21.11s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • test_flask_iast_ast_patching_import_error - test_flask_iast_patching.py

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.78%. Comparing base (7f679b3) to head (bca184f).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9213       +/-   ##
===========================================
- Coverage   78.58%    6.78%   -71.81%     
===========================================
  Files        1277     1247       -30     
  Lines      120397   118615     -1782     
===========================================
- Hits        94611     8045    -86566     
- Misses      25786   110570    +84784     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented May 9, 2024

Benchmarks

Benchmark execution time: 2024-05-10 16:14:08

Comparing candidate commit bca184f in PR branch avara1986/remove_telemetry_flaky_tests with baseline commit 7f679b3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@avara1986 avara1986 marked this pull request as ready for review May 10, 2024 08:53
@avara1986 avara1986 requested a review from a team as a code owner May 10, 2024 08:53
@avara1986 avara1986 enabled auto-merge (squash) May 10, 2024 09:30
@avara1986 avara1986 disabled auto-merge May 13, 2024 07:27
@avara1986 avara1986 enabled auto-merge (squash) May 13, 2024 07:28
@juanjux juanjux disabled auto-merge May 13, 2024 07:30
@juanjux juanjux merged commit 7847145 into main May 13, 2024
103 checks passed
@juanjux juanjux deleted the avara1986/remove_telemetry_flaky_tests branch May 13, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants