Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): remove abseil cpp dependency #9221

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented May 10, 2024

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 10, 2024

Datadog Report

Branch report: gnufede/remove-abseil-cpp-dependency
Commit report: 703adc9
Test service: dd-trace-py

✅ 0 Failed, 109278 Passed, 3716 Skipped, 6m 25.21s Total duration (43m 18.9s time saved)

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.78%. Comparing base (7847145) to head (703adc9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9221       +/-   ##
===========================================
- Coverage   78.58%    6.78%   -71.81%     
===========================================
  Files        1277     1247       -30     
  Lines      120395   118654     -1741     
===========================================
- Hits        94610     8047    -86563     
- Misses      25785   110607    +84822     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnufede gnufede marked this pull request as ready for review May 10, 2024 10:26
@gnufede gnufede requested a review from a team as a code owner May 10, 2024 10:26
@gnufede gnufede added the ASM Application Security Monitoring label May 10, 2024
remove absl include in code
@gnufede gnufede force-pushed the gnufede/remove-abseil-cpp-dependency branch from 4021ce9 to 7e771c0 Compare May 10, 2024 11:32
@pr-commenter
Copy link

pr-commenter bot commented May 10, 2024

Benchmarks

Benchmark execution time: 2024-05-13 09:07:52

Comparing candidate commit 703adc9 in PR branch gnufede/remove-abseil-cpp-dependency with baseline commit d0f56ab in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants