Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llmobs): remove invocations of LLMObs.enable() from supported integrations #9226

Closed
wants to merge 16 commits into from

Conversation

sabrenner
Copy link
Contributor

@sabrenner sabrenner commented May 10, 2024

Changes Made

Removing all mentions of LLMObs.enable() from integration patching, as that patching logic was moved to LLMObs.enable() itself. This change is reflected as necessary in tests as well.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@sabrenner sabrenner changed the title fix(llmobs): do not error patching on LLMObs.enable() exception fix(llmobs): do not error on integration patching on LLMObs.enable() exception May 10, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 10, 2024

Datadog Report

Branch report: sabrenner/llmobs-apm-fix
Commit report: da0f71d
Test service: dd-trace-py

✅ 0 Failed, 2264 Passed, 722 Skipped, 1h 7m 44.72s Total duration (30m 48.47s time saved)

@sabrenner sabrenner added the changelog/no-changelog A changelog entry is not required for this PR. label May 10, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 10, 2024

Benchmarks

Benchmark execution time: 2024-05-14 14:36:23

Comparing candidate commit da0f71d in PR branch sabrenner/llmobs-apm-fix with baseline commit cee0c7b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@sabrenner sabrenner marked this pull request as ready for review May 14, 2024 14:08
@sabrenner sabrenner requested review from a team as code owners May 14, 2024 14:08
Copy link
Contributor

@Yun-Kim Yun-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better maintainable way to fix this is to remove any LLMObs.enable() mentions in integration patch code, since the LLMObs.enable() function will handle the actual openai/langchain/bedrock patching once #9172 is merged.

@sabrenner
Copy link
Contributor Author

@Yun-Kim Good point. I can make the change and once those PRs are merged, check that the tests are still good.

@sabrenner sabrenner changed the title fix(llmobs): do not error on integration patching on LLMObs.enable() exception fix(llmobs): remove invocations of LLMObs.enable() from supported integrations May 14, 2024
@sabrenner
Copy link
Contributor Author

sabrenner commented May 16, 2024

Closing in favor of #9172, which will include this change and relevant test changes

@sabrenner sabrenner closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants