Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(distributed_tracing): ensure last datadog parent id tag is always set #9231

Merged
merged 2 commits into from May 13, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented May 10, 2024

This reverts commit 2230214.

W3C-Datadog header specification has significant gaps and needs to be revised. This change is unreleased so a release note is not required.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur marked this pull request as ready for review May 10, 2024 18:24
@mabdinur mabdinur requested a review from a team as a code owner May 10, 2024 18:24
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label May 10, 2024
@mabdinur mabdinur enabled auto-merge (squash) May 10, 2024 18:36
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 10, 2024

Datadog Report

Branch report: revert-9174-munir/w3c-changes-2-3
Commit report: 2a1af83
Test service: dd-trace-py

✅ 0 Failed, 169168 Passed, 2269 Skipped, 9h 4m 12.33s Total duration (45m 4.54s time saved)

@pr-commenter
Copy link

pr-commenter bot commented May 10, 2024

Benchmarks

Benchmark execution time: 2024-05-13 20:53:26

Comparing candidate commit 2a1af83 in PR branch revert-9174-munir/w3c-changes-2-3 with baseline commit de5efd3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 6.70%. Comparing base (de5efd3) to head (2a1af83).

Files Patch % Lines
ddtrace/propagation/http.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9231       +/-   ##
===========================================
- Coverage   75.60%    6.70%   -68.91%     
===========================================
  Files        1283     1253       -30     
  Lines      120889   119107     -1782     
===========================================
- Hits        91403     7987    -83416     
- Misses      29486   111120    +81634     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mabdinur mabdinur merged commit 3e34d21 into main May 13, 2024
200 checks passed
@mabdinur mabdinur deleted the revert-9174-munir/w3c-changes-2-3 branch May 13, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants