New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(asm): ensure new aspects does not raise exceptions if there is no context #9234
Conversation
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Datadog ReportBranch report: ✅ 0 Failed, 109278 Passed, 3716 Skipped, 6m 7.24s Total duration (43m 49.8s time saved) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9234 +/- ##
===========================================
- Coverage 78.58% 6.78% -71.81%
===========================================
Files 1277 1247 -30
Lines 120397 118617 -1780
===========================================
- Hits 94611 8045 -86566
- Misses 25786 110572 +84786 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-05-10 21:02:15 Comparing candidate commit ad6a4d3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics. |
…DataDog/dd-trace-py into juanjux/ensure-no-expections-on-aspects
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport-9234-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d0f56abd6053409b0f00fd7d8a77c199fa5ccd36
# Push it to GitHub
git push --set-upstream origin backport-9234-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9 Then, create a pull request where the |
… context (#9234) ## Description Ensure the new aspect don't raise exceptions if there is no tx_map, instead just return the original function result. ## Checklist - [X] Change(s) are motivated and described in the PR description - [X] Testing strategy is described if automated tests are not included in the PR - [X] Risks are described (performance impact, potential for breakage, maintainability) - [X] Change is maintainable (easy to change, telemetry, documentation) - [X] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [X] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [X] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [X] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com> Co-authored-by: Alberto Vara <alberto.vara@datadoghq.com> (cherry picked from commit d0f56ab)
Description
Ensure the new aspect don't raise exceptions if there is no tx_map, instead just return the original function result.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist