Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): convert serverless slow import test to a subprocess test #9236

Merged
merged 2 commits into from May 13, 2024

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented May 11, 2024

This test was messing with the global state of sys.modules. It was causing some modules to get unloaded causing them to get re-imported, which would cause issues.

Moving this test to a subprocess test will help isolate the behavior it is trying to test, and simplifies the test setup.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label May 11, 2024
@brettlangdon brettlangdon requested a review from a team as a code owner May 11, 2024 12:17
@brettlangdon brettlangdon changed the title chore(ci): convert slow import test to a subprocess test chore(ci): convert serverless slow import test to a subprocess test May 11, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 11, 2024

Datadog Report

Branch report: brettlangdon/fix.serverless.test
Commit report: 08c0a31
Test service: dd-trace-py

✅ 0 Failed, 1326 Passed, 636 Skipped, 3m 14.92s Total Time

@brettlangdon brettlangdon enabled auto-merge (squash) May 11, 2024 12:42
@pr-commenter
Copy link

pr-commenter bot commented May 11, 2024

Benchmarks

Benchmark execution time: 2024-05-13 18:15:15

Comparing candidate commit 08c0a31 in PR branch brettlangdon/fix.serverless.test with baseline commit 2ac3363 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@brettlangdon brettlangdon merged commit a85ba90 into main May 13, 2024
97 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/fix.serverless.test branch May 13, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants